On 5/16/2014 7:22 AM, Thomas Monjalon wrote: > Hi Cyril, > > 2014-04-03 10:30, Cyril Chemparathy: >> This patch series contains a few minor extensions to test-pmd. These >> changes have been added primarily for convenience while testing out various >> scenarios with DPDK. >> >> Cyril Chemparathy (6): >> test-pmd: add support for single port loopback topology >> test-pmd: add support for auto-start when interactive >> test-pmd: allow command line selection of forwarding mode >> test-pmd: allow txpkts to be setup via command line >> test-pmd: add mac swap forwarding mode >> test-pmd: add flowgen forwarding engine > Thanks for these new features. > > This is not the first time a new engine is added by copy/pasting the most part > of an existing engine. For instance, the "mac-retry" engine was added by Intel > as a copy/paste of the original "mac" one. > This is acceptable but not the perfect way to implement engines. > To address this issue, a new engine function could be introduced to setup some > parameters to be used by "packet_fwd" function. This way, similar engines > could be removed.
Agreed that it sucks to incessantly replicate code. Maybe some of the packet_fwd code is common enough to bump into run_pkt_fwd_on_lcore()? Most of these forwarding modes have similar looking code to receive/transmit bursts and free the failed remnants of the burst. Could this common code be bumped up into run_pkt_fwd_on_lcore() maybe? > Acked-by: Thomas Monjalon <thomas.monjalon at 6wind.com> > > Applied for version 1.7.0. Thanks! Much appreciated. -- Cyril.