Hi, Thomas The generic you said may be different from I mentioned in last mail. You are discussing whether the APIs provide for NIC filters is generic or not. About that we can use same API for a type of filter. For example, if we want to configure ethertype filter, we can use the same API, no matter the NIC is 82580, i350, 82576 or 82599. We think these NICs may be most common used.
-----Original Message----- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wu, Jingjing Sent: Wednesday, May 28, 2014 8:53 AM To: Thomas Monjalon Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 0/4] NIC filters support for generic filter Hi, Thomas This patch is mainly about multiple NIC filters implement. It has close relationship with NICs. As the patch says: NIC filters list below are implemented in this patchset: ethertype filter, syn filter, 2tuple filter and flex filter for 82580 and i350 ethertype filter, syn filter, 5tuple filter for 82576 ethertype filter, syn filter and 5tuple filter for 82599 The same type filter uses the same API for the NICs list above. About the generic filter feature, how to define the "generic" is still in discussing, and not included in this patch. These NIC filters implemented in this patch are first step. Even without generic, it also provides a way to configure these NIC filters to hardware in DPDK PMD. -----Original Message----- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Wednesday, May 28, 2014 7:22 AM To: Wu, Jingjing Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 0/4] NIC filters support for generic filter Hi Jingjing, 2014-05-24 09:37, Jingjing Wu: > A generic filter mechanism for handling special packet is required. > It will allow filters to be set in HW when available so that specific > packet may be filtered by NICs to specific descriptor queues for > processing. Currently only Flow Director for Intel's 10GbE 82599 > devices is available. Other types of filter are not support. > NIC filters list below are implemented in this patchset: > ethertype filter, syn filter, 2tuple filter and flex filter for > 82580 and > i350 ethertype filter, syn filter, 5tuple filter for 82576 > ethertype filter, syn filter and 5tuple filter for 82599 I'd like we have a discussion about how this API is generic enough. I think many people would like to integrate drivers for other NICs in DPDK and I'd hate to see a global rework of this API because we haven't tried to think about it before. First, is there someone in the mailing list who knows other hardware which could fit in this filtering feature? Thanks -- Thomas
