Hi Olivier, 2014-05-28 13:47, Olivier MATZ: > On 05/27/2014 02:55 PM, Thomas Monjalon wrote: > > Some linker options were not prefixed by -Wl, when using gcc: > > -z muldefs > > -melf_i386 (32-bit config) > > > > Using macro linkerprefix is fixing it. > > > > Signed-off-by: Thomas Monjalon <thomas.monjalon at 6wind.com> > > The patch looks correct, but from the commit log it's difficult > to understand what is the problem today. Is there a compilation > issue? Or is it just cleaning?
You're right, title should be: mk: fix 32-bit link with gcc And I should add some details in the commit log: I didn't see any error with -z muldefs but it isn't documented in gcc manual. So it's safer to explicitly pass it to the linker. The variable CPU_LDFLAGS contains "-melf_i386" in 32-bit configurations. So building 32-bit shared library raises this error: gcc: error: unrecognized command line option ?-melf_i386? Olivier, I'll make these changes if you (or Neil) ack the patch. Thanks for review -- Thomas