Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, November 04, 2014 6:17 AM > To: Chen, Jing D > Cc: dev at dpdk.org; Ananyev, Konstantin > Subject: Re: [PATCH v2 1/6] ether: enhancement for VMDQ support > > 2014-10-16 18:07, Chen Jing D: > > /** > > + * Simple flags to indicate RX mq mode, which can be used independently > or combined > > + * in enum rte_eth_rx_mq_mode definition. > > + */ > > +#define ETH_MQ_RX_RSS_FLAG 0x1 > > +#define ETH_MQ_RX_DCB_FLAG 0x2 > > +#define ETH_MQ_RX_VMDQ_FLAG 0x4 > > The comment would be more useful by explaining that these flags are used > for rte_eth_conf.rxmode.mq_mode.
Yes, that's more straightforward. > > > + /**< None of DCB,RSS or VMDQ mode */ > > + ETH_MQ_RX_NONE = 0, > > + > > + /**< For RX side, only RSS is on */ > > + ETH_MQ_RX_RSS = ETH_MQ_RX_RSS_FLAG, > > + /**< For RX side,only DCB is on. */ > > + ETH_MQ_RX_DCB = ETH_MQ_RX_DCB_FLAG, > > + /**< Both DCB and RSS enable */ > > + ETH_MQ_RX_DCB_RSS = ETH_MQ_RX_RSS_FLAG | > ETH_MQ_RX_DCB_FLAG, > > + > > + /**< Only VMDQ, no RSS nor DCB */ > > + ETH_MQ_RX_VMDQ_ONLY = ETH_MQ_RX_VMDQ_FLAG, > > + /**< RSS mode with VMDQ */ > > + ETH_MQ_RX_VMDQ_RSS = ETH_MQ_RX_RSS_FLAG | > ETH_MQ_RX_VMDQ_FLAG, > > + /**< Use VMDQ+DCB to route traffic to queues */ > > + ETH_MQ_RX_VMDQ_DCB = ETH_MQ_RX_VMDQ_FLAG | > ETH_MQ_RX_DCB_FLAG, > > + /**< Enable both VMDQ and DCB in VMDq */ > > + ETH_MQ_RX_VMDQ_DCB_RSS = ETH_MQ_RX_RSS_FLAG | > ETH_MQ_RX_DCB_FLAG | > > + ETH_MQ_RX_VMDQ_FLAG, > > Doxygen comments placed before should start with /** not /**<. My mistake. Thanks for pointing it out. > > > + /** Specify the queue range belongs to VMDQ pools if VMDQ > applicable. */ > > + uint16_t vmdq_queue_base; > > + uint16_t vmdq_queue_num; > > Please explain what mean the values in vmdq_queue_base and > vmdq_queue_num. I thinks the name is self- explanatory, I also add some comments for them. As previous max_rx/tx_queues indicates how many queues available, these 2 variables defines the queue ranges for VM usage. What kind of explanations you needs me to add? > > Thanks > -- > Thomas