Hi Thomas > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, November 6, 2014 4:53 AM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 7/8] ethdev: support of multiple sizes of > redirection table > > 2014-10-31 17:03, Helin Zhang: > > #define ETH_RSS_RETA_SIZE_64 64 > > #define ETH_RSS_RETA_SIZE_128 128 > > #define ETH_RSS_RETA_SIZE_512 512 > > Are these values still needed? It was widely used in igb/ixgbe/i40e code, and app/testpmd. It is good to be kept there, though we can define them separately in each component. This would be more convenient for PMDs and user applications.
> Why 256 is forbidden? 256 is not a valid table size of current supported NICs, for other/future NIC which supports this size, it can be added later as needed. > Maybe that some comments are needed here. Comments might not be needed, as their names tell us what they are clearly. Did you mean any other annotations to be added for these macros? I am open for that to add any good annotations for them. > > > +#define RTE_RETA_GROUP_SIZE 64
