Hi Konstantin, On 11/12/2014 06:21 PM, Ananyev, Konstantin wrote: >>> This patch introduces 2 new functions rte_get_rx_ol_flag_name() >>> and rte_get_tx_ol_flag_name() that returns the name of a flag from >>> its mask. It also fixes rxonly.c to use this new functions and to >>> display the proper flags. >> >> Good idea. Couple of minor comments below. > > Yes, that looks like a good idea to me too. > Just one thought - there is probably no need to make rte_get_*_ol_flag_name() > inlined > and put them into rte_mbuf.h > Seems like rte_mbuf.c - is a good place for these 2 functions definitions. > > Konstantin >
Agree, I'll add this change to the list. Thanks, Olivier
