On Mon, Nov 17, 2014 at 04:52:50PM +0000, Bruce Richardson wrote: > On Mon, Nov 17, 2014 at 04:40:19PM +0000, Nicolas Pernas Maradei wrote: > > > > On 17/11/14 16:00, Neil Horman wrote: > > >I get that, I was more asking, why those values? They seem a bit magic to > > >me, > > >and might benefit from some descriptive macros or comments so they make > > >more > > >sense > > >Neil > > OK, I get you now. > > > > Maybe the diff is not very clear. I just left the original calls to > > rte_eal_devargs_add() with the original values which they looked clear to me > > but I don't mind improving the comments a bit and as you suggested, adding > > in some macros. > > > > I'll wait for some more feedback before submitting a second version of the > > patch. > > > > Those are just example values for testing the parsing functionality. I'm don't > think descriptive macros are particularly needed, though maybe a short comment > or two might help out. The specific numeric values themselves aren't really > important, > they are just examples of different patterns. > > /Bruce > >
Agreed, if they're just arbitrary bus/dev/func values, Marcos aren't needed, just a comment calling them out as such. Thanks! Neil
