On Mon, Oct 06, 2014 at 10:49:46AM -0400, Neil Horman wrote:
> On Mon, Oct 06, 2014 at 11:52:31AM +0100, Sergio Gonzalez Monroy wrote:
> > As per the proposal, this patch set does:
> >  - Remove CONFIG_RTE_BUILD_COMBINE_LIBS as a configuration option.
> >  - For static library, build a single/combined library.
> >  - For shared libraries, build both individual/separated and single/combined
> >    libraries.
> >  - Link apps only against single/combined libs.
> > 
> > 
> > Sergio Gonzalez Monroy (4):
> >   Link combined shared library using CC
> >   Link apps only against single/combined library
> >   Update library build process
> >   Link apps/DSOs against EXECENV_LDLIBS with --as-needed
> > 
> >  config/common_bsdapp   |   3 +-
> >  config/common_linuxapp |   3 +-
> >  mk/rte.app.mk          | 164 
> > ++-----------------------------------------------
> >  mk/rte.lib.mk          |  81 ++++++------------------
> >  mk/rte.sdkbuild.mk     |   2 +-
> >  mk/rte.sharelib.mk     |  54 ++++++++--------
> >  mk/rte.vars.mk         |   4 --
> >  7 files changed, 54 insertions(+), 257 deletions(-)
> > 
> > -- 
> > 1.9.3
> > 
> > 
> 
> I see you removed the --whole-archive option when building the single library
> here.  Have you checked to make sure that all the constructors haven't been
> stripped out?

I am not entirely sure I follow. There is no --whole-archive when building 
libraries,
at least not in my sources.
The flag is used when linking apps and I have not removed it as you can see on 
patch 2/4.

Sergio

> Neil
> 

Reply via email to