> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jijiang Liu
> Sent: Saturday, October 11, 2014 6:56 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v5 4/8]librte_ether:add a common filter API
>
> Introduce a new filter framewok in librte_ether. As to the implemetation
> discussion, please refer to
> http://dpdk.org/ml/archives/dev/2014-September/005179.html, and VxLAN
> tunnel filter implementation is based on
> it.
>
> Signed-off-by: Jijiang Liu <jijiang.liu at intel.com>
> Acked-by: Helin Zhang <helin.zhang at intel.com>
> Acked-by: Jingjing Wu <jingjing.wu at intel.com>
>
[..]
> new file mode 100644
> index 0000000..574e9ff
> --- /dev/null
> +++ b/lib/librte_ether/rte_eth_ctrl.h
[...]
> +/**
> + * All generic operations to filters
> + */
> +enum rte_filter_op {
> + /**< used to check whether the type filter is supported */
Shouldn't be this comment below?
> + RTE_ETH_FILTER_OP_NONE = 0,
> + RTE_ETH_FILTER_OP_ADD, /**< add filter entry */
> + RTE_ETH_FILTER_OP_UPDATE, /**< update filter entry */
> + RTE_ETH_FILTER_OP_DELETE, /**< delete filter entry */
> + RTE_ETH_FILTER_OP_GET, /**< get filter entry */
> + RTE_ETH_FILTER_OP_SET, /**< configurations */
> + /**< get information of filter, such as status or statistics */
Same here
> + RTE_ETH_FILTER_OP_GET_INFO,
> + RTE_ETH_FILTER_OP_MAX,
> +};
> +
