> -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Friday, October 17, 2014 10:08 AM > To: Wu, Jingjing > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: new filter APIs definition > > 2014-10-17 07:29, Jingjing Wu: > > Define new APIs to support configure multi-kind filters using same APIs, > > instead of creating each API set for each kind of filter. > > - rte_eth_dev_filter_supported > > - rte_eth_dev_filter_ctrl > > > > Filter types, operations, and structures are defined specifically > > in new header file lib/librte_eth/rte_dev_ctrl.h. > > > > As to the implementation discussion, please refer to > > http://dpdk.org/ml/archives/dev/2014-September/005179.html > [...] > > --- /dev/null > > +++ b/lib/librte_ether/rte_eth_ctrl.h > > Why this name? I think we can reserve this file for filtering API. > So rte_eth_rx_filter.h would be more appropriate. > > > +/** > > + * All generic operations to filters > > + */ > > rewording: "Generic operations on filters" > Could you elaborate on "generic"? What would mean "specific"? > > > +enum rte_filter_op { > > + RTE_ETH_FILTER_OP_NONE = 0, > > + /**< used to check whether the type filter is supported */ > > + RTE_ETH_FILTER_OP_ADD, /**< add filter entry */ > > + RTE_ETH_FILTER_OP_UPDATE, /**< update filter entry */ > > + RTE_ETH_FILTER_OP_DELETE, /**< delete filter entry */ > > + RTE_ETH_FILTER_OP_FLUSH, /**< flush all entries */ > > + RTE_ETH_FILTER_OP_GET, /**< get filter entry */ > > + RTE_ETH_FILTER_OP_SET, /**< configurations */ > > + RTE_ETH_FILTER_OP_GET_INFO, > > Could we remove "OP", except for OP_NONE and OP_MAX?
OP_NONE ==> NOP or NOOP perhaps? /Bruce