2014-10-21 08:28, Ouyang, Changchun: > From: De Lara Guarch, Pablo > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > > > 2014-10-21 14:59, Ouyang Changchun: > > > > Fix the compilation issue in vector PMD when macro RTE_MBUF_REFCNT > > > > is disabled. > > > > > > > > Signed-off-by: Changchun Ouyang <changchun.ouyang at intel.com> > > > > > > Acked-by: Thomas Monjalon <thomas.monjalon at 6wind.com> > > > > > > Applied > > > > I was checking this patch right now, and I come across a second compilation > > issue, because rte_mbuf_refcnt_update and rte_pktmbuf_attach are not > > declared, and Bond PMD and IP fragmentation libraries use those functions. > > > > I guess that it is late to NACK this :P, but we require a second patch to > > fix > > completely this issue. > > As it fixes the compilation issue in vpmd, so no reason to NACK it, :-)
Exact > In my config, both BOND and IP fragment is disabled. So I don't come across > your issues. > Yes, agree with you, we need another patch to fix compilation issue in other > both places. Yes, I'm aware of these limitations. Please, first explain why mbuf refcnt is needed for these features. Then we have 2 options: remove the dependency or add more ifdefs. Thanks -- Thomas
