Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:[email protected]] > Sent: Tuesday, May 08, 2018 22:43 > To: Xu, Rosen <[email protected]> > Cc: [email protected]; Doherty, Declan <[email protected]>; > Richardson, Bruce <[email protected]>; [email protected]; > Yigit, Ferruh <[email protected]>; Ananyev, Konstantin > <[email protected]>; Zhang, Tianfei <[email protected]>; > Liu, Song <[email protected]>; Wu, Hao <[email protected]>; > [email protected] > Subject: Re: [PATCH v9 1/4] bus/ifpga: Add Intel FPGA BUS Library > > 08/05/2018 16:19, Xu, Rosen: > > --- /dev/null > > +++ b/drivers/bus/ifpga/rte_bus_ifpga_version.map > > + ifpga_get_integer32_arg; > > + ifpga_get_string_arg; > > + rte_ifpga_driver_register; > > + rte_ifpga_driver_unregister; > > All exported symbols must start with rte_
I will fix it in v10. > > > --- a/drivers/bus/meson.build > > +++ b/drivers/bus/meson.build > > -drivers = ['dpaa', 'fslmc', 'pci', 'vdev'] > > +drivers = ['dpaa', 'fslmc', 'pci', 'vdev', 'ifpga'] > > Would be better sorted in alphabetical order (between fslmc and pci). > Same comment in files config/common_base and drivers/bus/Makefile. I will fix in in v10.
