>-----Original Message----- >From: Trahe, Fiona [mailto:[email protected]] >Sent: 08 May 2018 20:14 >To: Verma, Shally <[email protected]>; De Lara Guarch, Pablo ><[email protected]> >Cc: Doherty, Declan <[email protected]>; Athreya, Narayana Prasad ><[email protected]>; Sahu, Sunila ><[email protected]>; Gupta, Ashish <[email protected]>; >[email protected]; Sahu, Sunila <[email protected]>; >Gupta, Ashish <[email protected]> >Subject: RE: [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev > >Hi Shally, > > >> -----Original Message----- >> From: Shally Verma [mailto:[email protected]] >> Sent: Thursday, April 5, 2018 12:25 PM >> To: De Lara Guarch, Pablo <[email protected]> >> Cc: Doherty, Declan <[email protected]>; Trahe, Fiona >> <[email protected]>; >> [email protected]; [email protected]; >> [email protected]; >> [email protected]; Sunila Sahu <[email protected]>; Ashish Gupta >> <[email protected]> >> Subject: [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev >> >> struct rte_cryptodev_sym_session * >> rte_cryptodev_sym_session_create(struct rte_mempool *mp) >> { >> struct rte_cryptodev_sym_session *sess; >> >> /* Allocate a session structure from the session pool */ >> - if (rte_mempool_get(mp, (void **)&sess)) { >> + if (rte_mempool_get(mp, (void *)&sess)) { >[Fiona] Are you introducing a bug here? >The fn expects a void ** [Shally] Ya. My bad. Missed it.
>Also this will need rebasing - the latest code has an extra byte.
