> -----Original Message----- > From: Van Haaren, Harry > Sent: Wednesday, May 9, 2018 10:19 AM > To: Carrillo, Erik G <[email protected]> > Cc: [email protected]; Vangati, Narender > <[email protected]>; Eads, Gage <[email protected]>; > [email protected] > Subject: RE: [PATCH v1 1/1] service: Add service lcore attr APIs > > > -----Original Message----- > > From: Carrillo, Erik G > > Sent: Friday, May 4, 2018 9:16 PM > > To: Van Haaren, Harry <[email protected]> > > Cc: [email protected]; Vangati, Narender > > <[email protected]>; Eads, Gage <[email protected]>; > > [email protected] > > Subject: [PATCH v1 1/1] service: Add service lcore attr APIs > > > > Add a counter that gets bumped each time the service runner loop goes > > around, and APIs to query and reset the attribute values. > > > > Signed-off-by: Erik Gabriel Carrillo <[email protected]> > > From cover letter for this patch: > > This patch proposes the addition of an API which allows an application to > query the attributes of a service lcore. It adds one such new attribute, > named "loops", which is a counter that tracks the number of times the > service core has looped in the service runner function (the driver function > that invokes services mapped to a service core). This is useful to > applications > that desire a "liveness" check to make sure a service core is not stuck. > > > When sending a single patch it is not required to send with --cover-letter. > > I like the description provided in the cover letter, perhaps merge the current > commit message with the cover-letter paragraph? > > For the v2, please include > > Acked-by: Harry van Haaren <[email protected]> >
Thanks for the review, Harry. I'll make the changes and resubmit.
