Hi, Zhang Qi Thanks for your feedback. I've just submitted v5 patch to follow your guidance.
> -----Original Message----- > From: Zhang, Qi Z > Sent: Saturday, May 19, 2018 8:19 AM > To: Dai, Wei <[email protected]>; Lu, Wenzhuo <[email protected]>; > Ananyev, Konstantin <[email protected]>; Wu, Yanglong > <[email protected]>; Yigit, Ferruh <[email protected]> > Cc: [email protected] > Subject: RE: [PATCH v4] net/ixgbe: config VLAN strip on the fly > > > > > -----Original Message----- > > From: Dai, Wei > > Sent: Saturday, May 19, 2018 12:09 AM > > To: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin > > <[email protected]>; Zhang, Qi Z <[email protected]>; > > Wu, Yanglong <[email protected]>; Yigit, Ferruh > > <[email protected]> > > Cc: [email protected]; Dai, Wei <[email protected]> > > Subject: [PATCH v4] net/ixgbe: config VLAN strip on the fly > > > > The old ixgbe_vlan_offload_set() is called by > > rte_eth_dev_set_vlan_offload() which is meant to config VLAN > > strip/filter/extend on all queues. > > This old function is also called by > > rte_eth_dev_start()/ixgbe_dev_start() > > OK, I think this is what we missed in previous patch, good capture, thanks! > > > which need support per-queue VALN strip on only parts of queues. > > So add new function ixgbe_vlan_offload_config() = old > > ixgbe_vlan_offload_set(). > > New ixgbe_vlan_offload_set = codes to align VLAN strip flags on all > > queues with port level setting + ixgbe_vlan_offload_configure(). > > > > Signed-off-by: Wei Dai <[email protected]> > > Signed-off-by: Yanglong Wu <[email protected]> > > Though the code can be improved to remove some redundant , but I think > it's not a big deal right now. > BTW, I think we still need the fixed line, so it will be added during apply. > > Fixes: 860a94d3c692 ("net/ixgbe: support VLAN strip per queue offloading in > VF") > > Acked-by: Qi Zhang <[email protected]>
