Hi Ophir, Thanks for inputs, please find my answers inline to the mail
> -----Original Message----- > From: Ophir Munk [mailto:[email protected]] > Sent: Tuesday, May 22, 2018 8:35 PM > To: Varghese, Vipin <[email protected]>; [email protected]; Yigit, Ferruh > <[email protected]>; Wiles, Keith <[email protected]> > Cc: Thomas Monjalon <[email protected]>; Olga Shern > <[email protected]> > Subject: RE: [PATCH v3] net/tap: perform proto field update for tun only > > Hi, > Overall it looks good. > Please note a few more comments below. > > > -----Original Message----- > > From: Vipin Varghese [mailto:[email protected]] > > Sent: Tuesday, May 22, 2018 1:47 PM > > To: [email protected]; [email protected]; [email protected]; Ophir > > Munk <[email protected]> > > Cc: Thomas Monjalon <[email protected]>; Olga Shern > > <[email protected]>; Vipin Varghese <[email protected]> > > Subject: [PATCH v3] net/tap: perform proto field update for tun only > > > > The TX function is shared between TAP and TUN PMD. Checking TUN-TAP > > type field will ensure the TAP PMD will always have protocol field as 0. > > > > Signed-off-by: Vipin Varghese <[email protected]> > > Suggested-by: Ferruh Yigit <[email protected]> > > --- > > Shouldn't it be a fix commit? The following code base is not merged with stable, dev or next-net branch. Hence do we 'fix commit' this? > If so - please update the commit title, add Fixes: ... , Cc: > [email protected]... > > > Changes in V3: > > - remove type field from rx struct - Ophir Munk > > - add space for comment in struct - Ophir Munk > > - pass type field into eth_dev_tap_create - Ophir Munk > > - replace with enum value for type - Ophir Munk > > - return as 'not supported' for mac_set - Vipin Varghese > > > > Changes in V2: > > - updated in comment wording - Keith Wiles > > - remove debug print from tx code - Keith Wiles > > --- > > drivers/net/tap/rte_eth_tap.c | 61 > > +++++++++++++++++++++++++------------- > > ----- > > drivers/net/tap/rte_eth_tap.h | 9 +++++++ > > 2 files changed, 45 insertions(+), 25 deletions(-) > > <Snipped> > > > > + if (pmd->type == ETH_TUNTAP_TYPE_TUN) > > + return -ENOTSUP; > > > Can you please add a TAP_LOG(ERR, ...) to log this error similar to other > error > cases in this function? Yes, I will add the change in v4 and share the same. > > > + <Snipped>
