Thanks Bruce, I submitted v10 patch set fixing the whitespace issues.
> -----Original Message----- > From: Bruce Richardson <bruce.richard...@intel.com> > Sent: Thursday, June 14, 2018 6:45 PM > To: Gavin Hu <gavin...@arm.com> > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 7/7] devtools: expand meson cross > compiling coverage > > On Thu, Jun 14, 2018 at 05:51:27PM +0800, Gavin Hu wrote: > > The default test script covers only default host cc compiler, either > > gcc or clang, the fix is to cover both, gcc and clang. And also the > > build dirs are changed to *-host-$c, indicating the difference of cc used. > > > > Fixes: a55277a788 ("devtools: add test script for meson builds") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Gavin Hu <gavin...@arm.com> > > Reviewed-by: Phil Yang <phil.y...@arm.com> > > Reviewed-by: Song Zhu <song....@arm.com> > > --- > Given that the only native code we have in a cross-build is pmdinfogen, doing > two copies of each cross-build seems overkill, and makes the test longer than > it should be. I suggest that we just do one of the cross-builds, e.g. the > generic > armv8 one, for both clang and gcc, and do the others only once. > > /Bruce IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.