> -----Original Message----- > From: Burakov, Anatoly > Sent: Monday, June 18, 2018 4:51 PM > To: Zhang, Qi Z <[email protected]>; [email protected] > Cc: Ananyev, Konstantin <[email protected]>; [email protected]; > Richardson, Bruce <[email protected]>; Yigit, Ferruh > <[email protected]>; Shelton, Benjamin H > <[email protected]>; Vangati, Narender > <[email protected]> > Subject: Re: [PATCH 06/22] ethdev: support attach or detach share device > from secondary > > > > + else > > + return -1; > > + do { > > + ret = rte_mp_request_async(&mp_req, &ts, clb); > > + } while (ret != 0 && rte_errno == EEXIST); > > + > > + if (ret) > > + ethdev_log(ERR, "couldn't send async request\n"); > > + entry = find_request_by_id(req->id > + (void)entry; > > Why did you look up entry and then marked it as used without checking the > return value? Leftover? Some code missing?
Some debug code forgot be removed :) BTW, also accept all other comments Thanks Qi
