On Tue, Sep 16, 2014 at 01:13:24PM +0100, reshmapa wrote: > From: Reshma Pattan <reshma.pattan at intel.com> > > A new sample app that shows the usage of the distributor library. This > app works as follows: > > *An RX thread runs which pulls packets from each ethernet port in turn > and passes those packets to worker using a distributor component. > > *The workers take the packets in turn, and determine the output port > for those packets using basic l2forwarding doing an xor on the source > port id. > > *The RX thread takes the returned packets from the workers and enqueue > those packets into an rte_ring structure. > > *A TX thread pulls the packets off the rte_ring structure and then > sends each packet out the output port specified previously by the worker > > Bruce Richardson (1): > distributor_app: new sample app > > Reshma Pattan (2): > distributor_app: code review comments implementation > distributor_app: removed extra spaces >
Since this is just a sample app and the second two patches are just minor adjustments to it, I suggest that this be resubmitted as a single patch instead of a set. That should also fix the whitespace warnings one gets when using "git am" to apply the set. Please also check the indentation used in the file. I see in a number of places that spaces are used instead of tabs for indentation. Running checkpatch.pl on the patch before submission should help catch these issues. Regards, /Bruce > examples/Makefile | 1 + > examples/distributor_app/Makefile | 57 ++++ > examples/distributor_app/main.c | 586 > ++++++++++++++++++++++++++++++++++++++ > examples/distributor_app/main.h | 46 +++ > 4 files changed, 690 insertions(+) > create mode 100644 examples/distributor_app/Makefile > create mode 100644 examples/distributor_app/main.c > create mode 100644 examples/distributor_app/main.h > > -- > 1.8.3.1 >