>-----Original Message-----
>From: De Lara Guarch, Pablo [mailto:[email protected]]
>Sent: 23 June 2018 23:47
>To: Verma, Shally <[email protected]>
>Cc: Trahe, Fiona <[email protected]>; [email protected]; [email protected]; 
>Athreya, Narayana Prasad
><[email protected]>; Sahu, Sunila <[email protected]>; 
>Gupta, Ashish <[email protected]>
>Subject: RE: [PATCH v3 5/6] crypto/openssl: add asym crypto support
>
>External Email
// snip

>> >>Yes, but the name is still session_configure/clear, not
>> sym_session_configure/clear, right?
>> >>And also, I think we should rename the OpenSSL functions,
>> >>openssl_pmd_session_*, to openssl_pmd_sym_session_*.
>> >>
>> >[Shally] Ok. I will look into this.
>> >
>> [Shally] if I change these names in struct rte_cryptodev_ops, then we will 
>> need
>> to change all drivers. I think that should be done in a separate patch series
>> specific to rename these. For now, I will rename only openssl pmd APIs to use
>> _sym version for this patch series.
>
>Right. I think a separate patch is a good idea, but it has to be done in one 
>patch,
>to avoid breaking the compilation. Could you send this patch soon?
>
I can send openssl asym related patch soon. Can't commit on right now for sym_ 
session name  in pmd ops changes.
Sorry about that.

Thanks
Shally

>Thanks,
>Pablo
>
>>
>> >Thanks
>> >Shally
>> >
>> >>Pablo
>> >>
>> >>>
>> >>> Thanks for review.
>> >>>
>> >>> >Thanks,
>> >>> >Pablo
>> >>> >

Reply via email to