>-----Original Message----- >From: De Lara Guarch, Pablo [mailto:[email protected]] >Sent: 25 June 2018 22:10 >To: Verma, Shally <[email protected]>; Akhil Goyal ><[email protected]>; Doherty, Declan <[email protected]>; >[email protected]; Jacob, Jerin <[email protected]>; >Zhang, Roy Fan <[email protected]>; Trahe, >Fiona <[email protected]>; [email protected]; [email protected] >Cc: [email protected] >Subject: RE: [dpdk-dev] [PATCH 5/6] cryptodev: remove old get session size >functions > >External Email > >> -----Original Message----- >> From: Verma, Shally [mailto:[email protected]] >> Sent: Friday, June 22, 2018 6:02 PM >> To: Akhil Goyal <[email protected]>; De Lara Guarch, Pablo >> <[email protected]>; Doherty, Declan >> <[email protected]>; [email protected]; Jacob, Jerin >> <[email protected]>; Zhang, Roy Fan >> <[email protected]>; Trahe, Fiona <[email protected]>; >> [email protected]; [email protected] >> Cc: [email protected] >> Subject: RE: [dpdk-dev] [PATCH 5/6] cryptodev: remove old get session size >> functions >> >> Hi Pablo >> >> >-----Original Message----- >> >From: dev [mailto:[email protected]] On Behalf Of Akhil Goyal >> >Sent: 21 June 2018 18:29 >> >To: Pablo de Lara <[email protected]>; >> >[email protected]; [email protected]; Jacob, Jerin >> ><[email protected]>; [email protected]; >> >[email protected]; [email protected]; [email protected] >> >Cc: [email protected] >> >Subject: Re: [dpdk-dev] [PATCH 5/6] cryptodev: remove old get session >> >size functions >> > >> >External Email >> > >> >Hi Pablo, >> > >> > >> >On 6/9/2018 3:32 AM, Pablo de Lara wrote: >> >> Removed rte_cryptodev_get_header_session_size >> >> and rte_cryptodev_get_private_session_size functions, as they have >> >> been substituted with functions specific for symmetric operations, >> >> with _sym_ word after "rte_cryptodev_". >> >> >> >> Signed-off-by: Pablo de Lara <[email protected]> >> >> --- > >... > >> >> + >> >> + - ``rte_cryptodev_get_header_session_size`` is replaced with >> >> + ``rte_cryptodev_sym_get_header_session_size`` >> >> + - ``rte_cryptodev_get_private_session_size`` is replaced with >> >> + ``rte_cryptodev_sym_get_private_session_size`` >> >> + >> >rte_cryptodev_get_private_session_size is not removed in this patch. I >> >think you missed it in your patch. > >Right Akhil, thanks for spotting this. Will fix in next version. > >> > >> >-Akhil >> >> >> >> ABI Changes >> >> ----------- >> >> diff --git a/lib/librte_cryptodev/rte_cryptodev.c >> >> b/lib/librte_cryptodev/rte_cryptodev.c >> >> index a07904fb9..40e249e79 100644 >> >> --- a/lib/librte_cryptodev/rte_cryptodev.c >> >> +++ b/lib/librte_cryptodev/rte_cryptodev.c >> >> @@ -1181,12 +1181,6 @@ rte_cryptodev_sym_session_free(struct >> rte_cryptodev_sym_session *sess) >> >> return 0; >> >> } >> >> >> >> -unsigned int >> >> -rte_cryptodev_get_header_session_size(void) >> >> -{ >> >> - return rte_cryptodev_sym_get_header_session_size(); >> >> -} >> >> - >> >> unsigned int >> >> rte_cryptodev_sym_get_header_session_size(void) >> >> { >> >> [Shally] I missed this before. I think this implementation either should >> change to >> use nb_drivers which support symmetric or else I am not seeing a need for >> separate sym specific API for header_size since it will always be same for >> both >> sym and asym. > >The implementation is already using nb_drivers to calculate the size, right? [Shally] I meant change it to nb_sym_drivers, where nb_sym_drivers = number of drivers that have symmetric capability
>Anyway, I understand that the way asymmetric sessions are done, the API >will be the same, but this could change in the future and since we have >already deprecated the >generic function (get_header_session_size), I think we should continue and >have both _sym and _asym_ functions. > [Shally] Ok. >Thanks, >Pablo
