> -----Original Message----- > From: Burakov, Anatoly > Sent: Tuesday, June 26, 2018 7:48 PM > To: Zhang, Qi Z <[email protected]>; [email protected] > Cc: Ananyev, Konstantin <[email protected]>; [email protected]; > Richardson, Bruce <[email protected]>; Yigit, Ferruh > <[email protected]>; Shelton, Benjamin H > <[email protected]>; Vangati, Narender > <[email protected]> > Subject: Re: [PATCH v4 01/24] eal: introduce one device scan > > On 26-Jun-18 8:08 AM, Qi Zhang wrote: > > When hot plug a new device, it is not necessary to scan everything on > > the bus since the devname and devargs are already there. So new > > rte_bus ops "scan_one" is introduced, bus driver can implement this > > function to simplify the hotplug process. > > > > Signed-off-by: Qi Zhang <[email protected]> > > --- > > > > <snip> > > > + * NULL for unsuccessful scan > > + */ > > +typedef struct rte_device *(*rte_bus_scan_one_t)(struct rte_devargs > > +*devargs); > > + > > +/** > > * Implementation specific probe function which is responsible for linking > > * devices on that bus with applicable drivers. > > * > > @@ -204,6 +219,7 @@ struct rte_bus { > > TAILQ_ENTRY(rte_bus) next; /**< Next bus object in linked list */ > > const char *name; /**< Name of the bus */ > > rte_bus_scan_t scan; /**< Scan for devices attached to > bus */ > > + rte_bus_scan_one_t scan_one; /**< Scan one device using devargs */ > > rte_bus_probe_t probe; /**< Probe devices on bus */ > > rte_bus_find_device_t find_device; /**< Find a device on the bus */ > > rte_bus_plug_t plug; /**< Probe single device for drivers > */ > > > > Does changing this structure break ABI for bus drivers?
For bus driver, I think yes, but I'm not sure what I should do for this, since this is not for application > > -- > Thanks, > Anatoly
