On 6/29/2018 12:55 AM, Thomas Monjalon wrote: > 20/06/2018 19:15, Ferruh Yigit: >> On 6/20/2018 6:07 PM, Dan Gora wrote: >>> Hi Ferruh, >>> >>> The documentation for rte_eth_dev_configure() should get updated as >>> well to document this requirement to strip the unsupported RSS hash >>> function bits. The current documentation only refers to the tx/rx >>> offload bits: >>> >>> * - Any offloading set in eth_conf->[rt]xmode.offloads must be within >>> * the [rt]x_offload_capa returned from rte_eth_dev_infos_get(). >>> * Any type of device supported offloading set in the input argument >>> * eth_conf->[rt]xmode.offloads to rte_eth_dev_configure() is enabled >>> * on all queues and it can't be disabled in >>> rte_eth_[rt]x_queue_setup(). >> >> Agreed, will update the patch according. > > I don't see the doc updated in your v2.
I have missed it, sending new version with the update.
