Hi, 02/07/2018 07:44, Qi Zhang: > --- a/lib/librte_ethdev/rte_ethdev_driver.h > +++ b/lib/librte_ethdev/rte_ethdev_driver.h > @@ -70,6 +70,19 @@ int rte_eth_dev_release_port(struct rte_eth_dev *eth_dev); > > /** > * @internal > + * Release the specified ethdev port in local process, only set to ethdev > + * state to unused, but not reset share data since it assume other process > + * is still using it, typically it is called by secondary process.
Please check grammar in doxygen comments, and do not make long sentences. "only set to ethdev state to unused" -> "only set ethdev state to unused" "share" -> "shared" "it assume" -> "it assumes" Please split sentences with a dot and an uppercase. I expect all patches of the series must be reviewed for english wording. > + * > + * @param eth_dev > + * The *eth_dev* pointer is the address of the *rte_eth_dev* structure. This comment is useless. You can just say "Device to be detached". > + * @return > + * - 0 on success, negative on error > + */ > +int rte_eth_dev_release_port_private(struct rte_eth_dev *eth_dev); [...] > --- a/lib/librte_ethdev/rte_ethdev_pci.h > +++ b/lib/librte_ethdev/rte_ethdev_pci.h > @@ -197,6 +197,9 @@ rte_eth_dev_pci_generic_remove(struct rte_pci_device > *pci_dev, > + if (rte_eal_process_type() != RTE_PROC_PRIMARY) > + return rte_eth_dev_release_port_private(eth_dev); This is a behaviour change. It means a PCI device cannot be globally detached directly by a secondary. It must be justified by a comment in the code. Please explain.
