Re: [dpdk-dev] [PATCH v1 2/3] app/crypto-perf: honour cryptodev's min headroom/tailroom

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com]
> Sent: Wednesday, July 4, 2018 2:56 PM
> To: Doherty, Declan <declan.dohe...@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.gua...@intel.com>
> Cc: Anoob Joseph <anoob.jos...@caviumnetworks.com>; Akhil Goyal
> <akhil.go...@nxp.com>; Ankur Dwivedi
> <ankur.dwiv...@caviumnetworks.com>; Jerin Jacob
> <jerin.ja...@caviumnetworks.com>; Narayana Prasad
> <narayanaprasad.athr...@caviumnetworks.com>; dev@dpdk.org
> Subject: [PATCH v1 2/3] app/crypto-perf: honour cryptodev's min
> headroom/tailroom
> 
> Crypto dev would specify its headroom and tailroom requirement and the
> application is expected to honour this while creating buffers.
> 
> Signed-off-by: Anoob Joseph <anoob.jos...@caviumnetworks.com>

...

> --- a/app/test-crypto-perf/cperf_test_common.c
> +++ b/app/test-crypto-perf/cperf_test_common.c

...

> fill_multi_seg_mbuf(struct rte_mbuf *m, struct rte_mempool *mp,
>               m->buf_iova = next_seg_phys_addr;
>               next_seg_phys_addr += mbuf_hdr_size + segment_sz;
>               m->buf_len = segment_sz;
> -             m->data_len = segment_sz;
> +             m->data_len = data_len;
> 
> -             /* No headroom needed for the buffer */
> -             m->data_off = 0;
> +             /* Use headroom specified for the buffer */
> +             m->data_off = headroom;

Headroom is only applicable for the first segment/s.
This is adding headroom in all the segments, which looks wrong.