Hi Shally,
> -----Original Message-----
> From: Shally Verma [mailto:[email protected]]
> Sent: Thursday, July 12, 2018 3:09 PM
> To: De Lara Guarch, Pablo <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; Sunila Sahu
> <[email protected]>; Ashish Gupta
> <[email protected]>
> Subject: [PATCH v4 1/3] crypto/openssl: add rsa and mod asym op
>
> From: Sunila Sahu <[email protected]>
>
> - Add compat.h to make pmd compatible to openssl-1.1.0 and
> backward version
> - Add rsa sign/verify/encrypt/decrypt and modular operation
> support
>
> Signed-off-by: Sunila Sahu <[email protected]>
> Signed-off-by: Shally Verma <[email protected]>
> Signed-off-by: Ashish Gupta <[email protected]>
...
> --- a/drivers/crypto/openssl/rte_openssl_pmd.c
> +++ b/drivers/crypto/openssl/rte_openssl_pmd.c
...
> + case RTE_CRYPTO_ASYM_OP_VERIFY:
> + ret = RSA_public_decrypt(op->rsa.sign.length,
> + op->rsa.sign.data,
> + op->rsa.sign.data,
> + rsa,
> + pad);
> +
> + OPENSSL_LOG(DEBUG,
> + "Length of public_decrypt %d "
> + "length of message %zd\n",
> + ret, op->rsa.message.length);
> +
> + if (memcmp(op->rsa.sign.data, op->rsa.message.data,
> + op->rsa.message.length)) {
> + OPENSSL_LOG(ERR,
> + "RSA sign Verification failed");
> + return -1;
> + }
There is a compilation issue here (missing "break"?):
drivers/crypto/openssl/rte_openssl_pmd.c:1905:6: error:
this statement may fall through [-Werror=implicit-fallthrough=]
if (memcmp(op->rsa.sign.data, op->rsa.message.data,
^
> + default:
> + /* allow ops with invalid args to be pushed to
> + * completion queue
> + */
> + cop->status = RTE_CRYPTO_OP_STATUS_INVALID_ARGS;
> + break;
> + }
