> -----Original Message-----
> From: Verma, Shally [mailto:[email protected]]
> Sent: Monday, July 23, 2018 1:53 PM
> To: De Lara Guarch, Pablo <[email protected]>
> Cc: [email protected]; Athreya, Narayana Prasad
> <[email protected]>; Challa, Mahipal
> <[email protected]>; Gupta, Ashish <[email protected]>;
> Sahu, Sunila <[email protected]>; Sahu, Sunila
> <[email protected]>
> Subject: RE: [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue
>
> Hi Pablo
>
> >-----Original Message-----
> >From: De Lara Guarch, Pablo <[email protected]>
> >Sent: 23 July 2018 18:07
> >To: Verma, Shally <[email protected]>
> >Cc: [email protected]; Athreya, Narayana Prasad
> ><[email protected]>; Challa, Mahipal
> ><[email protected]>; Gupta, Ashish <[email protected]>;
> >Sahu, Sunila <[email protected]>; Sahu, Sunila
> ><[email protected]>
> >Subject: RE: [PATCH v3 4/5] compress/zlib: support burst
> >enqueue/dequeue
> >
> >External Email
> >
> >> -----Original Message-----
> >> From: Shally Verma [mailto:[email protected]]
> >> Sent: Saturday, July 21, 2018 7:18 PM
> >> To: De Lara Guarch, Pablo <[email protected]>
> >> Cc: [email protected]; [email protected];
> >> [email protected]; [email protected];
> >> [email protected]; Sunila Sahu
> >> <[email protected]>
> >> Subject: [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue
> >>
> >> From: Sunila Sahu <[email protected]>
> >>
> >> Signed-off-by: Sunila Sahu <[email protected]>
> >> Signed-off-by: Shally Verma <[email protected]>
> >> Signed-off-by: Ashish Gupta <[email protected]>
> >> ---
> >> drivers/compress/zlib/zlib_pmd.c | 254
> >
> >...
> >
> >> +def_end:
> >> + /* Update op stats */
> >> + switch (op->status) {
> >> + case RTE_COMP_OP_STATUS_SUCCESS:
> >> + op->consumed += strm->total_in;
> >
> >Compilation issue here:
> >
> >drivers/compress/zlib/zlib_pmd.c:94:16: error: this statement may fall
> >through
> [-Werror=implicit-fallthrough=]
> > op->consumed += strm->total_in;
> > ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
> >
> >I think you are missing a "/* Fall-through */" comment here.
> OK. I will send next patch immediately with this fix. But which compiler
> version
> you following, since this isn't seen during our build (which we did on
> multiple
> platforms) so want to understand what is the environment we need to have to
> avoid such regressions.
I see this with gcc 7.2.1 (on Fedora 27).
Pablo
>
> Thanks
> Shally
>
> >
> >Thanks,
> >Pablo
> >
> >> + case RTE_COMP_OP_STATUS_OUT_OF_SPACE_TERMINATED:
> >> + op->produced += strm->total_out;
> >> + break;
