>-----Original Message-----
>From: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>
>Sent: 24 July 2018 03:33
>To: Verma, Shally <shally.ve...@cavium.com>
>Cc: dev@dpdk.org; Athreya, Narayana Prasad
><narayanaprasad.athr...@cavium.com>; Challa, Mahipal
><mahipal.cha...@cavium.com>; Gupta, Ashish <ashish.gu...@cavium.com>; Sahu,
>Sunila <sunila.s...@cavium.com>
>Subject: RE: [PATCH v4 2/5] compress/zlib: add device PMD ops
>
>External Email
>
>> -----Original Message-----
>> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com]
>> Sent: Monday, July 23, 2018 3:51 PM
>> To: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>
>> Cc: dev@dpdk.org; pathr...@caviumnetworks.com;
>> mcha...@caviumnetworks.com; Ashish Gupta
>> <ashish.gu...@caviumnetworks.com>; Sunila Sahu
>> <sunila.s...@caviumnetworks.com>
>> Subject: [PATCH v4 2/5] compress/zlib: add device PMD ops
>>
>> From: Ashish Gupta <ashish.gu...@caviumnetworks.com>
>>
>> Implement device configure and queue pair setup PMD ops
>>
>> Signed-off-by: Sunila Sahu <sunila.s...@caviumnetworks.com>
>> Signed-off-by: Shally Verma <shally.ve...@caviumnetworks.com>
>> Signed-off-by: Ashish Gupta <ashish.gu...@caviumnetworks.com>
>
>...
>
>> --- /dev/null
>> +++ b/drivers/compress/zlib/zlib_pmd_ops.c
>> @@ -0,0 +1,238 @@
>> +/* SPDX-License-Identifier: BSD-3-Clause
>> + * Copyright(c) 2018 Cavium Networks
>> + */
>> +
>> +#include <string.h>
>> +
>> +#include <rte_common.h>
>> +#include <rte_malloc.h>
>> +
>> +#include "zlib_pmd_private.h"
>> +
>> +static const struct rte_compressdev_capabilities zlib_pmd_capabilities[] = {
>> + { /* Deflate */
>> + .algo = RTE_COMP_ALGO_DEFLATE,
>> + .comp_feature_flags =
>> (RTE_COMP_FF_NONCOMPRESSED_BLOCKS |
>> + RTE_COMP_FF_HUFFMAN_FIXED |
>> + RTE_COMP_FF_HUFFMAN_DYNAMIC |
>> +
>> RTE_COMP_FF_OOP_SGL_IN_SGL_OUT),
>
>As said in the document patch, I think you should add the other two SGL cases
>here.
Would give thought to it however, prefer to hold back on their support until we
evaluate them with proper testcases.
Thanks
Shally
