Hi, Bernard Thanks for your feedback and guidance. I have just submitted a v2 patch to include modification on document.
Thanks & Best Regrards -Wei > -----Original Message----- > From: Iremonger, Bernard > Sent: Tuesday, July 24, 2018 10:22 PM > To: Dai, Wei <wei....@intel.com>; Wu, Jingjing <jingjing...@intel.com>; Lu, > Wenzhuo <wenzhuo...@intel.com>; dev@dpdk.org > Cc: Dai, Wei <wei....@intel.com>; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some > offload > > Hi Wei, > > > -----Original Message----- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Dai > > Sent: Tuesday, July 24, 2018 4:45 AM > > To: Wu, Jingjing <jingjing...@intel.com>; Lu, Wenzhuo > > <wenzhuo...@intel.com>; dev@dpdk.org > > Cc: Dai, Wei <wei....@intel.com>; sta...@dpdk.org > > Subject: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some > > offload > > > > Without this patch, testpmd command to config Rx offload keep_crc > > would fail and report "Bad argument". > > This patch aslo fix the command to config the Tx offload mbuf_fast_free. > > > > Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") > > Fixes: c73a9071877a ("app/testpmd: add commands to test new offload > > API") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Wei Dai <wei....@intel.com> > > --- > > app/test-pmd/cmdline.c | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > 5885289..a0ed3a0 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -16665,7 +16665,7 @@ struct > cmd_config_per_port_rx_offload_result { > > offload, > > "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" > > "qinq_strip#outer_ipv4_cksum#macsec_strip#" > > > > "header_split#vlan_filter#vlan_extend#jumbo_frame#" > > - "crc_strip#scatter#timestamp#security"); > > + "crc_strip#scatter#timestamp#security#keep_crc"); > > cmdline_parse_token_string_t > > cmd_config_per_port_rx_offload_result_on_off = > > TOKEN_STRING_INITIALIZER > > (struct cmd_config_per_port_rx_offload_result, > > @@ -16744,7 +16744,7 @@ struct > cmd_config_per_port_rx_offload_result { > > .help_str = "port config <port_id> rx_offload > > vlan_strip|ipv4_cksum|" > > > > "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" > > "macsec_strip|header_split|vlan_filter|vlan_extend|" > > - "jumbo_frame|crc_strip|scatter|timestamp|security " > > + > > "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " > > "on|off", > > .tokens = { > > (void *)&cmd_config_per_port_rx_offload_result_port, > > @@ -16794,7 +16794,7 @@ struct > cmd_config_per_queue_rx_offload_result > > { > > offload, > > "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" > > "qinq_strip#outer_ipv4_cksum#macsec_strip#" > > > > "header_split#vlan_filter#vlan_extend#jumbo_frame#" > > - "crc_strip#scatter#timestamp#security"); > > + "crc_strip#scatter#timestamp#security#keep_crc"); > > cmdline_parse_token_string_t > > cmd_config_per_queue_rx_offload_result_on_off = > > TOKEN_STRING_INITIALIZER > > (struct cmd_config_per_queue_rx_offload_result, > > @@ -16846,7 +16846,7 @@ struct > cmd_config_per_queue_rx_offload_result > > { > > "vlan_strip|ipv4_cksum|" > > > > "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" > > "macsec_strip|header_split|vlan_filter|vlan_extend|" > > - "jumbo_frame|crc_strip|scatter|timestamp|security " > > + > > "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " > > "on|off", > > .tokens = { > > (void *)&cmd_config_per_queue_rx_offload_result_port, > > @@ -17063,7 +17063,7 @@ struct > cmd_config_per_port_tx_offload_result { > > > > "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" > > "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" > > "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" > > - "mt_lockfree#multi_segs#fast_free#security"); > > + > > "mt_lockfree#multi_segs#mbuf_fast_free#security"); > > cmdline_parse_token_string_t > > cmd_config_per_port_tx_offload_result_on_off = > > TOKEN_STRING_INITIALIZER > > (struct cmd_config_per_port_tx_offload_result, > > @@ -17144,7 +17144,7 @@ struct > cmd_config_per_port_tx_offload_result { > > "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" > > "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" > > "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" > > - "mt_lockfree|multi_segs|fast_free|security " > > + "mt_lockfree|multi_segs|mbuf_fast_free|security " > > "on|off", > > .tokens = { > > (void *)&cmd_config_per_port_tx_offload_result_port, > > @@ -17195,7 +17195,7 @@ struct > cmd_config_per_queue_tx_offload_result > > { > > > > "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" > > "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" > > "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" > > - "mt_lockfree#multi_segs#fast_free#security"); > > + > > "mt_lockfree#multi_segs#mbuf_fast_free#security"); > > cmdline_parse_token_string_t > > cmd_config_per_queue_tx_offload_result_on_off = > > TOKEN_STRING_INITIALIZER > > (struct cmd_config_per_queue_tx_offload_result, > > @@ -17248,7 +17248,7 @@ struct > cmd_config_per_queue_tx_offload_result > > { > > "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" > > "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" > > "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" > > - "mt_lockfree|multi_segs|fast_free|security " > > + "mt_lockfree|multi_segs|mbuf_fast_free|security " > > "on|off", > > .tokens = { > > (void *)&cmd_config_per_queue_tx_offload_result_port, > > -- > > 1.8.3.1 > > Changes are also needed in > dpdk/doc/guides/testpmd_app_guide/testpmd_funcs.rst for mbuf_fast_free > and keep_crc. > > Regards, > > Bernard
