> -----Original Message----- > From: Andrew Rybchenko [mailto:[email protected]] > Sent: Sunday, August 12, 2018 6:51 PM > To: Zhang, Qi Z <[email protected]>; [email protected]; > [email protected]; Burakov, Anatoly <[email protected]> > Cc: Ananyev, Konstantin <[email protected]>; [email protected]; > Richardson, Bruce <[email protected]>; Yigit, Ferruh > <[email protected]>; Shelton, Benjamin H > <[email protected]>; Vangati, Narender > <[email protected]> > Subject: Re: [dpdk-dev] [PATCH v14 5/6] drivers/net: enable device detach on > secondary > > On 10.08.2018 03:42, Qi Zhang wrote: > > With the enabling for hotplug on multi-process, it is not necessary to > > prevent detaching a device from a secondary process. > > > > Signed-off-by: Qi Zhang <[email protected]> > > From the patch itself including description it is absolutely unclear why > detach works and where it actually happens.
OK, I will add more detail comment. > Why is it OK to return 0 instead of error and that's it. Obviously , something need to fix, since uninit is not only called by driver->remove > Why is it necessary to call uninit at all in the case of secondary processes? Will parse NULL to rte_eth_dev_pci_generic_remove for secondary process.
