On 7/5/2018 1:34 PM, Wiles, Keith wrote: > > >> On Jul 4, 2018, at 3:11 PM, Thomas Monjalon <tho...@monjalon.net> wrote: >> >> 04/07/2018 21:47, Ferruh Yigit: >>> On 6/12/2018 3:02 PM, Ophir Munk wrote: >>>> Please note that other than cloning iproute2 we also need to install clang >>>> and llvm tools versions 3.7 and upper. >>>> Not sure there are clang and llvm packages of the required versions for >>>> the common distributions. >>>> I compiled the tools source code and installed them manually. >>> >>> Hi Keith, Thomas, >>> >>> What do you suggest on this patch? >>> >>> The "tap_bpf_program.c" is already withing the tap pmd this patch improves >>> the >>> doc about how to compile it, although it may not be so user friendly as >>> Keith >>> pointed, I believe better to get doc improvement here. >>> >>> And there is a code update "+#include "bpf_api.h", which includes a iproute2 >>> header, I am not sure about this one and how to manage this dependency. >> >> If you feel it needs some improvement, we can postpone it for 18.11. >> The most important is to have a patch to reference when somebody asks. >> >> It can be improved and merged later, no pressure. > > I agree.
Hi Ophir, Are you planning a new version of patch for this release? Thanks, ferruh
