Re-ordered the guide-pdf-% and guide-% rules to allow the doc-guides-pdf target to build with make 3.81. It builds unmodified with all later versions of make.
Reported-by: Tetsuya Mukawa <mukawa at igel.co.jp> Signed-off-by: John McNamara <john.mcnamara at intel.com> --- mk/rte.sdkdoc.mk | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/mk/rte.sdkdoc.mk b/mk/rte.sdkdoc.mk index 5b44083..0b69d99 100644 --- a/mk/rte.sdkdoc.mk +++ b/mk/rte.sdkdoc.mk @@ -94,11 +94,6 @@ guides-pdf-img-clean: $(Q)rm -f $(RTE_SDK)/doc/guides/*/img/*.pdf guides-pdf: $(addprefix guides-pdf-, $(notdir $(RTE_GUIDES:/=))) ; -guides-%: - @echo 'sphinx processing $@...' - $(Q)$(RTE_SPHINX_BUILD) -b $* $(RTE_SPHINX_VERBOSE) \ - -c $(RTE_SDK)/doc/guides $(RTE_SDK)/doc/guides \ - $(RTE_OUTPUT)/doc/$*/guides guides-pdf-%: @echo 'sphinx processing $@...' @@ -112,6 +107,12 @@ guides-pdf-%: $(Q)mv $(RTE_OUTPUT)/doc/pdf/guides/$*/doc.pdf \ $(RTE_OUTPUT)/doc/pdf/guides/$*.pdf +guides-%: + @echo 'sphinx processing $@...' + $(Q)$(RTE_SPHINX_BUILD) -b $* $(RTE_SPHINX_VERBOSE) \ + -c $(RTE_SDK)/doc/guides $(RTE_SDK)/doc/guides \ + $(RTE_OUTPUT)/doc/$*/guides + # Each PDF depends on generated images *.pdf from *.svg $(foreach guide, $(RTE_GUIDES), $(foreach img, $(wildcard $(guide)img/*.svg), \ $(eval guides-pdf-$(notdir $(guide:/=)): $(img:svg=pdf)))) -- 1.8.1.4 Fix for issue: $ ~/tmp/make-3.81/make doc-guides-pdf sphinx processing guides-pdf-freebsd_gsg... Sphinx error: Builder name pdf-freebsd_gsg not registered make[1]: *** [guides-pdf-freebsd_gsg] Error 1 make: *** [doc-guides-pdf] Error 2