No users left for this function, time to deprecate it.
Signed-off-by: Adrien Mazarguil <[email protected]>
Cc: Thomas Monjalon <[email protected]>
Cc: Ferruh Yigit <[email protected]>
Cc: Andrew Rybchenko <[email protected]>
Cc: Gaetan Rivet <[email protected]>
--
v3 changes:
- Removed deprecation notice (finally got Ferruh's point), made patch last
in series.
v2 changes:
- Patch was not present in original series.
---
doc/guides/rel_notes/deprecation.rst | 7 -------
lib/librte_ethdev/rte_flow.h | 7 ++++++-
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/doc/guides/rel_notes/deprecation.rst
b/doc/guides/rel_notes/deprecation.rst
index e2dbee317..48cfb266b 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -88,10 +88,3 @@ Deprecation Notices
- ``rte_pdump_set_socket_dir`` will be removed;
- The parameter, ``path``, of ``rte_pdump_init`` will be removed;
- The enum ``rte_pdump_socktype`` will be removed.
-
-* ethdev: flow API function ``rte_flow_copy()`` will be deprecated in v18.11
- in favor of ``rte_flow_conv()`` (which will appear in that version) and
- subsequently removed for v19.02.
-
- This is due to a lack of flexibility and reliance on a type unusable with
- C++ programs (struct rte_flow_desc).
diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
index 052ceefb6..f062ffead 100644
--- a/lib/librte_ethdev/rte_flow.h
+++ b/lib/librte_ethdev/rte_flow.h
@@ -2332,6 +2332,7 @@ rte_flow_error_set(struct rte_flow_error *error,
const char *message);
/**
+ * @deprecated
* @see rte_flow_copy()
*/
struct rte_flow_desc {
@@ -2343,10 +2344,13 @@ struct rte_flow_desc {
};
/**
+ * @deprecated
* Copy an rte_flow rule description.
*
* This interface is kept for compatibility with older applications but is
- * implemented as a wrapper to rte_flow_conv().
+ * implemented as a wrapper to rte_flow_conv(). It is deprecated due to its
+ * lack of flexibility and reliance on a type unusable with C++ programs
+ * (struct rte_flow_desc).
*
* @param[in] fd
* Flow rule description.
@@ -2365,6 +2369,7 @@ struct rte_flow_desc {
* If len is lower than the size of the flow, the number of bytes that would
* have been written to desc had it been sufficient. Nothing is written.
*/
+__rte_deprecated
size_t
rte_flow_copy(struct rte_flow_desc *fd, size_t len,
const struct rte_flow_attr *attr,
--
2.11.0
