Hi Thomas, > What is the relation between link status timeout and qos_sched? [LCM] Validation team found qos_sched test failure on i40e. The sample depends on link speed to calc the percentage. The root cause comes from that i40e link_get hasn't support wait_to_complete well. I agree with you it should add more description in test report why 'Used QoS example to verified'.
> > +-----------------------+----------------------+ > > | Subport output rate | Subport output rate | > > | (% line rate) | (Mpps) | > > +-----------+-----------+----------+-----------+ > > | Expected | Actual | Expected | Actual | > > +-----------+-----------+----------+-----------+ > > This table is empty. [LCM] It's useless, should be omitted I think. Cunming > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, April 02, 2015 3:52 AM > To: Zhang, XiaonanX; Cao, Waterman > Cc: dev at dpdk.org; Zhang, Helin; Liang, Cunming > Subject: Re: [dpdk-dev] [PATCH] i40e: fix no effect wait_to_complete on > link_get > > Hi, > > 2015-04-01 06:10, Zhang, XiaonanX: > > > > Tested-by: Xiaonan zhang<xiaonanx.zhang at intel.com> > > > > - OS: Fedora21 3.19.1-201.fc21.x86_64 > > - GCC: gcc version 4.9.1 20140930 (Red Hat 4.9.1-11) (GCC) > > - CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz > > - NIC: Ethernet controller [0200]: Intel Corporation Ethernet Controller > > X710 for > 10GbE SFP+ [8086:1572] (rev 01) > > - Default x86_64-native-linuxapp-gcc configuration > > - Total 1 cases, 1 passed, 0 failed > > > > - Test case: Used Qos example to verified > > ------------------------------------- > > What is the relation between link status timeout and qos_sched? > > > Traffic shaping for subport. Check that the subport rate is enforced. > > > > Set the subport output rate to x% of line rate (x = 10 .. 100). Set the > > subport TC > limits high (100% line rate each), so they do not constitute limitations. > Input traffic > is 100% line rate. > > > > Different tb period and tb credits, therefore different output rate, are > > tried: > 25%, 50%, 75%, 90% and 100% the lineal rate. (The output for subport is Tb > credits > per period / Tb period.) > > The traffic is injected change subport value random. > > > > Other parameters are same before tests and they don't change here. > > > > Cmdline: ./examples/qos_sched/build/qos_sched -c 0xe -n 4 -- --pfc > "0,1,2,3,3" --cfg "/root/profile_sched_pipe_1.cfg" > > > > The result is this table: > > > > > > +-----------------------+----------------------+ > > | Subport output rate | Subport output rate | > > | (% line rate) | (Mpps) | > > +-----------+-----------+----------+-----------+ > > | Expected | Actual | Expected | Actual | > > +-----------+-----------+----------+-----------+ > > This table is empty. > > > > > Signed-off-by: Xiaonan Zhang <xiaonanx.zhang at intel.com> > > It seems that this test report is not relevant. > It will be ignored in the commit message. Sorry