Re: [dpdk-dev] [PATCH 14/15] net/vmxnet3: rename version map after library file name

[Yong Wang]

-----Original Message-----
From: Luca Boccassi <bl...@debian.org>
Date: Monday, September 10, 2018 at 1:05 PM
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "keith.wi...@intel.com" <keith.wi...@intel.com>, "roy.fan.zh...@intel.com" 
<roy.fan.zh...@intel.com>, "jingjing...@intel.com" <jingjing...@intel.com>, 
"wenzhuo...@intel.com" <wenzhuo...@intel.com>, "rasesh.m...@cavium.com" 
<rasesh.m...@cavium.com>, "harish.pa...@cavium.com" <harish.pa...@cavium.com>, 
"shahed.sha...@cavium.com" <shahed.sha...@cavium.com>, "amr.mokh...@intel.com" 
<amr.mokh...@intel.com>, "shijith.thot...@cavium.com" 
<shijith.thot...@cavium.com>, "ssriniva...@cavium.com" 
<ssriniva...@cavium.com>, "liang.j...@intel.com" <liang.j...@intel.com>, 
"peter.mccar...@intel.com" <peter.mccar...@intel.com>, 
"jerin.ja...@caviumnetworks.com" <jerin.ja...@caviumnetworks.com>, 
"maciej.cze...@caviumnetworks.com" <maciej.cze...@caviumnetworks.com>, 
"arybche...@solarflare.com" <arybche...@solarflare.com>, 
"antosh.shu...@caviumnetworks.com" <antosh.shu...@caviumnetworks.com>, 
"ashish.gu...@cavium.com" <ashish.gu...@cavium.com>, Yong Wang 
<yongw...@vmware.com>, "bruce.richard...@intel.com" 
<bruce.richard...@intel.com>, "tho...@monjalon.net" <tho...@monjalon.net>
Subject: [PATCH 14/15] net/vmxnet3: rename version map after library file name

    The library is called librte_pmd_vmxnet3_uio, so rename the map
    file and set the name in the meson file so that the built library names
    with meson and legacy makefiles are the same
    
    Signed-off-by: Luca Boccassi <bl...@debian.org>
    ---

Not directly related to this change but I have some question on the uio naming. 
 The original motivation is from the following commit:

commit 1daf0aae7fd6b3bc38952e9817a1653c1258be66
Author: Thomas Monjalon <thomas.monja...@6wind.com>
Date:   Fri Mar 21 13:52:17 2014 +0100

    vmxnet3: rename library
    
    In order to distinguish clearly this implementation from the extension
    vmxnet3-usermap, it is renamed to reflect its usage of uio framework.
    
    Signed-off-by: Thomas Monjalon <thomas.monja...@6wind.com>
    Acked-by: Thomas Graf <tg...@redhat.com>

However, this version of vmxnet3 can also be bound to vfio-pci driver.  I think 
having the uio naming in that case will be misleading. 

     drivers/net/vmxnet3/Makefile                                    | 2 +-
     ..._pmd_vmxnet3_version.map => rte_pmd_vmxnet3_uio_version.map} | 0
     2 files changed, 1 insertion(+), 1 deletion(-)
     rename drivers/net/vmxnet3/{rte_pmd_vmxnet3_version.map => 
rte_pmd_vmxnet3_uio_version.map} (100%)
    
    diff --git a/drivers/net/vmxnet3/Makefile b/drivers/net/vmxnet3/Makefile
    index f1141da674..9848cd224f 100644
    --- a/drivers/net/vmxnet3/Makefile
    +++ b/drivers/net/vmxnet3/Makefile
    @@ -43,7 +43,7 @@ LDLIBS += -lrte_bus_pci
     
     VPATH += $(SRCDIR)/base
     
    -EXPORT_MAP := rte_pmd_vmxnet3_version.map
    +EXPORT_MAP := rte_pmd_vmxnet3_uio_version.map
     
     LIBABIVER := 1
     
    diff --git a/drivers/net/vmxnet3/rte_pmd_vmxnet3_version.map 
b/drivers/net/vmxnet3/rte_pmd_vmxnet3_uio_version.map
    similarity index 100%
    rename from drivers/net/vmxnet3/rte_pmd_vmxnet3_version.map
    rename to drivers/net/vmxnet3/rte_pmd_vmxnet3_uio_version.map
    -- 
    2.18.0