Hi Jerin, Thanks for review, could you help review the v5 version?
Best Regards, Gavin > -----Original Message----- > From: Jerin Jacob <[email protected]> > Sent: Monday, September 17, 2018 6:35 PM > To: Gavin Hu (Arm Technology China) <[email protected]> > Cc: [email protected]; Honnappa Nagarahalli > <[email protected]>; Steve Capper > <[email protected]>; Ola Liljedahl <[email protected]>; nd > <[email protected]>; [email protected] > Subject: Re: [PATCH v3 3/3] doc: add cross compile part for sample > applications > > -----Original Message----- > > Date: Mon, 17 Sep 2018 10:28:57 +0000 > > From: "Gavin Hu (Arm Technology China)" <[email protected]> > > To: Jerin Jacob <[email protected]> > > CC: "[email protected]" <[email protected]>, Honnappa Nagarahalli > > <[email protected]>, Steve Capper > <[email protected]>, > > Ola Liljedahl <[email protected]>, nd <[email protected]>, > "[email protected]" > > <[email protected]> > > Subject: RE: [PATCH v3 3/3] doc: add cross compile part for sample > > applications > > > > > -----Original Message----- > > > From: Jerin Jacob <[email protected]> > > > Sent: Monday, September 17, 2018 5:48 PM > > > To: Gavin Hu (Arm Technology China) <[email protected]> > > > Cc: [email protected]; Honnappa Nagarahalli > > > <[email protected]>; Steve Capper > <[email protected]>; > > > Ola Liljedahl <[email protected]>; nd <[email protected]>; > > > [email protected] > > > Subject: Re: [PATCH v3 3/3] doc: add cross compile part for sample > > > applications > > > > > > -----Original Message----- > > > > Date: Mon, 17 Sep 2018 15:47:35 +0800 > > > > From: Gavin Hu <[email protected]> > > > > To: [email protected] > > > > CC: [email protected], [email protected], > > > > [email protected], [email protected], > > > > [email protected], [email protected], [email protected] > > > > Subject: [PATCH v3 3/3] doc: add cross compile part for sample > > > > applications > > > > X-Mailer: git-send-email 2.11.0 > > > > > > > > External Email > > > > > > > > Fixes: 7cacb05655 ("doc: add generic build instructions for sample > > > > apps") > > > > Cc: [email protected] > > > > > > > > Signed-off-by: Gavin Hu <[email protected]> > > > > Reviewed-by: Honnappa Nagarahalli <[email protected]> > > > > --- > > > > doc/guides/sample_app_ug/compiling.rst | 15 ++++++++++++++- > > > > 1 file changed, 14 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/doc/guides/sample_app_ug/compiling.rst > > > > b/doc/guides/sample_app_ug/compiling.rst > > > > index a2d75ed22..6f04743c8 100644 > > > > --- a/doc/guides/sample_app_ug/compiling.rst > > > > +++ b/doc/guides/sample_app_ug/compiling.rst > > > > @@ -9,7 +9,6 @@ This section explains how to compile the DPDK > > > > sample > > > applications. > > > > To compile all the sample applications > > > > -------------------------------------- > > > > > > > > - > > > > Set the path to DPDK source code if its not set: > > > > > > > > .. code-block:: console > > > > @@ -93,3 +92,17 @@ Build the application: > > > > > > > > export RTE_TARGET=build > > > > make > > > > + > > > > +To cross compile the sample application(s) > > > > +------------------------------------------ > > > > + > > > > +For cross compiling the sample application(s), please append > > > 'CROSS=$(CROSS_COMPILER_PREFIX)' to the 'make' command. > > > > +In example of AARCH64 cross compiling: > > > > + > > > > + .. code-block:: console > > > > + > > > > + export RTE_TARGET=build > > > > + export RTE_SDK=/path/to/rte_sdk > > > > + make -C examples CROSS=aarch64-linux-gnu- > > > > + or > > > > + make CROSS=aarch64-linux-gnu- > > > > > > It should be make -C examples/l3fwd CROSS=aarch64-linux-gnu-, Right? > > > as without giving directory it builds the SDK only. > > > > -C examples/l3fwd can be ignored if the $(pwd) is already in there. > > Yes. Since it mentioned as "or" it better to explicitly mentioned in it. > > i.e > > make -C examples CROSS=aarch64-linux-gnu- > > or > > cd $(pwd)/examples/<example_app> > make CROSS=aarch64-linux-gnu- > > or > > make -C examples/<example_app> CROSS=aarch64-linux-gnu- > > > > > > > > > > -- > > > > 2.11.0 > > > >
