Hi David, Thx for this feedback I'll be sending a new version with your suggestion.
Kindest regards, Raslan Darawsheh -----Original Message----- From: Jerin Jacob <[email protected]> Sent: Friday, September 14, 2018 9:35 AM To: David Marchand <[email protected]> Cc: Raslan Darawsheh <[email protected]>; Wu, Jingjing <[email protected]>; Thomas Monjalon <[email protected]>; [email protected]; Shahaf Shuler <[email protected]>; Xueming(Steven) Li <[email protected]> Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic function to dump packets -----Original Message----- > Date: Thu, 13 Sep 2018 18:43:02 +0200 > From: David Marchand <[email protected]> > To: Raslan Darawsheh <[email protected]> > Cc: "Wu, Jingjing" <[email protected]>, Thomas Monjalon > <[email protected]>, [email protected], Shahaf Shuler > <[email protected]>, [email protected] > Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic > function to dump packets > > > On Wed, Sep 12, 2018 at 10:06 AM, Raslan Darawsheh <[email protected]> > wrote: > > use the generic function to dump packets for several forwarding > > engines. > > Rather than patching some engines, how about putting this in rx/tx callbacks ? +1 to have zero performance impact on forward engines. > A bit like something I sent earlier ? > > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatc > hes.dpdk.org%2Fpatch%2F44465%2F&data=02%7C01%7Crasland%40mellanox. > com%7C9bbd72a1f31b4555b0be08d61a0c4402%7Ca652971c7d2e4d9ba6a4d149256f4 > 61b%7C0%7C0%7C636725037336863883&sdata=bWeN5Rsi0vrX5oPZYI5%2FChCZ4 > VogpRAiY6doOkT0Q8s%3D&reserved=0 > > > -- > David Marchand
