I'd like to point out that the comments inside eal_memory.c are outdated (e.g. the one from line #249). It makes it difficult to review this patch.
> -----Original Message----- > From: dev [mailto:[email protected]] On Behalf Of Pawel Wodkowski > Sent: Friday, September 21, 2018 1:57 PM > To: [email protected] > Cc: Wodkowski, PawelX <[email protected]> > Subject: [dpdk-dev] [PATCH] eal: fix '--huge-unlink' option > > The final_va field is set during remap_segment() but this information is not > propagated to temporal copy of huge page memory configuration so the > unlink_hugepage_files() function wrongly assume that there is nothing to > unlink. Fix this issue by checking orig_va instead of final_va. > > Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists") > To: Anatoly Burakov <[email protected]> > > Signed-off-by: Pawel Wodkowski <[email protected]>
