-----Original Message-----
> Date: Fri, 7 Sep 2018 11:06:24 +0100
> From: Kevin Laatz <[email protected]>
> To: [email protected]
> CC: [email protected], [email protected], [email protected],
> [email protected], Kevin Laatz <[email protected]>
> Subject: [PATCH v3 1/3] lib/librte_table: add hash_func header files
> X-Mailer: git-send-email 2.9.5
>
> This commit adds rte_table_hash_func.h and rte_table_hash_func_arm64.h to
> librte_table. This reduces code duplication by removing duplicate header files
> within two folders and consolidating them into a single one. This also adds a
> scalar implementation of the x86_64 intrinsic for crc32 as a generic fallback.
>
> Signed-off-by: Cristian Dumitrescu <[email protected]>
> Signed-off-by: Kevin Laatz <[email protected]>
> Acked-by: Gavin Hu <[email protected]>
> ---
> v2:
> - Fixed typo in commit message
> - Fixed typo in arm header that caused some compilations to fail for the
> entire patchset
> v3:
> - Improved commit message
ARM specific change and this patchset looks good. But, It has following
checkpatches.sh and check-git-log.sh errors.
➜ [master][dpdk.org] $ ./devtools/checkpatches.sh
### lib/librte_table: add hash_func header files
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description
(prefer a maximum 75 chars per line)
#7:
librte_table. This reduces code duplication by removing duplicate header
files
total: 0 errors, 1 warnings, 298 lines checked
ERROR: symbol rte_crc32_u64_generic is added in a section other than the
EXPERIMENTAL section of the version map
ERROR: symbol rte_table_hash_crc_key16 is added in a section other than
the EXPERIMENTAL section of the version map
ERROR: symbol rte_table_hash_crc_key24 is added in a section other than
the EXPERIMENTAL section of the version map
ERROR: symbol rte_table_hash_crc_key32 is added in a section other than
the EXPERIMENTAL section of the version map
ERROR: symbol rte_table_hash_crc_key40 is added in a section other than
the EXPERIMENTAL section of the version map
ERROR: symbol rte_table_hash_crc_key48 is added in a section other than
the EXPERIMENTAL section of the version map
ERROR: symbol rte_table_hash_crc_key56 is added in a section other than
the EXPERIMENTAL section of the version map
ERROR: symbol rte_table_hash_crc_key64 is added in a section other than
the EXPERIMENTAL section of the version map
ERROR: symbol rte_table_hash_crc_key8 is added in a section other than
the EXPERIMENTAL section of the version map
2/3 valid patches
➜ [master][dpdk.org] $ ./devtools/check-git-log.sh
Wrong headline format:
lib/librte_table: add hash_func header files
examples/ip_pipeline: modify application to use librte_table
headers
net/softnic: modify softnic to use librte_table headers
Headline too long:
examples/ip_pipeline: modify application to use librte_table
headers
Line too long:
librte_table. This reduces code duplication by removing
duplicate header files
within two folders and consolidating them into a single one.
This also adds a
scalar implementation of the x86_64 intrinsic for crc32 as a
generic fallback.
