Hi > -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Monday, April 13, 2015 8:55 PM > To: Raz Amir > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] Restore support for virtio on FreeBSD > > Please provide more information in the commit message. > We need to know what was the problem (crash) in the git history. > Then when doing git blame, we'll have the full explanation. > > 2015-04-13 15:19, Raz Amir: > > Fixes: 8a312224bcde ("eal/bsd: fix fd leak") > > > > Signed-off-by: Raz Amir <razamir22 at gmail.com> > > --- > > lib/librte_eal/bsdapp/eal/eal.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/librte_eal/bsdapp/eal/eal.c > > b/lib/librte_eal/bsdapp/eal/eal.c index 871d5f4..e20f915 100644 > > --- a/lib/librte_eal/bsdapp/eal/eal.c > > +++ b/lib/librte_eal/bsdapp/eal/eal.c > > @@ -426,7 +426,7 @@ rte_eal_iopl_init(void) > > fd = open("/dev/io", O_RDWR); > > if (fd < 0) > > return -1; > > - close(fd); > > + /* keep fd open for iopl */
Copy and paste my comment into this new patch: Would you pls think about this solution? Declare a static var to keep the fd which is opened for freebsd; Then define a deinit function for virtio device, Inside the deinit function, close the fd which was opened in init stage. Done. thanks Changchun
