Hi Gaetan
> -----Original Message-----
> From: dev [mailto:[email protected]] On Behalf Of Gaetan Rivet
> Sent: Friday, October 5, 2018 10:59 PM
> To: [email protected]
> Cc: Gaetan Rivet <[email protected]>; Yigit, Ferruh
> <[email protected]>
> Subject: [dpdk-dev] [PATCH v2] testpmd: sfp eeprom display
./devtools/check-git-log.sh
Wrong headline format:
myscripts: add setup_dpdk.sh
Wrong headline label:
testpmd: sfp eeprom display
Wrong headline lowercase:
testpmd: sfp eeprom display
>
> The interactive command
>
> show port sfp_eeprom <id>
>
> will dump the content of the SFP EEPROM for the selected port.
> Dumping SFP eeprom of all ports at once is not supported.
>
> Signed-off-by: Gaetan Rivet <[email protected]>
> ---
> app/test-pmd/cmdline.c | 9 +++++++--
> app/test-pmd/config.c | 32 ++++++++++++++++++++++++++++++++ app/test-
> pmd/testpmd.h | 1 +
There should also be an entry in the following file for this command:
dpdk/doc/guides/testpmd_app_ug/testpmd_funcs.rst
Should there be an entry in the release notes to announce this new testpmd
command?
> 3 files changed, 40 insertions(+), 2 deletions(-)
>
<snip>
Regards,
Bernard.