On 10/11/2018 11:35 AM, Igor Russkikh wrote:
> From: Pavel Belous <[email protected]>
>
> Add support for Rx/Tx descriptors status information.
>
> Signed-off-by: Igor Russkikh <[email protected]>
> Signed-off-by: Pavel Belous <[email protected]>
<...>
> @@ -191,6 +191,14 @@ static const struct eth_dev_ops atl_eth_dev_ops = {
>
> .rx_queue_intr_enable = atl_dev_rx_queue_intr_enable,
> .rx_queue_intr_disable = atl_dev_rx_queue_intr_disable,
> +
> + .rx_queue_count = atl_rx_queue_count,
> + .rx_descriptor_done = atl_dev_rx_descriptor_done,
> + .rx_descriptor_status = atl_dev_rx_descriptor_status,
> + .tx_descriptor_status = atl_dev_tx_descriptor_status,
`rx_descriptor_done` replace by `.rx_descriptor_status & .tx_descriptor_status`,
since you already have them no need to implement `rx_descriptor_done`
`rx_descriptor_done` is not removed because not all PMDs switch to new dev_ops.
Please remove `rx_descriptor_done`.
And we should document it better to prevent similar confusions.