On 10/11/2018 6:59 PM, Stephen Hemminger wrote:
> @@ -161,8 +161,9 @@ extern "C" {
>
> extern int rte_eth_dev_logtype;
>
> -#define RTE_ETHDEV_LOG(level, ...) \
> - rte_log(RTE_LOG_ ## level, rte_eth_dev_logtype, "" __VA_ARGS__)
> +#define RTE_ETHDEV_LOG(level, fmt, ...) \
> + rte_log(RTE_LOG_ ## level, rte_eth_dev_logtype, \
> + "%s():" fmt, __func__, ## __VA_ARGS__)
+1 to adding function name, but
failsafe is giving build error [1] with clang because of ## usage [2], that is
why I add this as ` "" __VA_ARGS__` at first place but you can't do this trick
if __VA_ARGS__ used after fmt.
I am not aware of a solution for this, __VA_OPT__(,) also didn't worked with
clang.
[1]
.../build/include/rte_ethdev.h:166:26: error: token pasting of ',' and
__VA_ARGS__ is a GNU extension [-Werror,-Wgnu-zero-variadic-macro-arguments]
"%s():" fmt, __func__, ## __VA_ARGS__)
^
[2]
This seems because of "-pedantic" argument driver uses, and other PMDs using
"-pedantic", like mlx, will have same error although they are disable by
default and error not observed in default build.
