> -----Original Message-----
> From: Laatz, Kevin
> Sent: Thursday, October 11, 2018 9:58 AM
> To: [email protected]
> Cc: Van Haaren, Harry <[email protected]>;
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; Richardson, Bruce
> <[email protected]>; Ciara Power <[email protected]>; Brian
> Archbold <[email protected]>; Laatz, Kevin <[email protected]>
> Subject: [PATCH v4 04/13] telemetry: add initial connection socket
> 
> From: Ciara Power <[email protected]>
> 
> This patch adds the telemetry UNIX socket. It is used to
> allow connections from external clients.
> 
> On the initial connection from a client, ethdev stats are
> registered in the metrics library, to allow for their retrieval
> at a later stage.
> 
> Signed-off-by: Ciara Power <[email protected]>
> Signed-off-by: Brian Archbold <[email protected]>
> Signed-off-by: Kevin Laatz <[email protected]>
> ---

<big snip>

> +static int32_t
> +rte_telemetry_create_socket(struct telemetry_impl *telemetry)
> +{
> +     int ret;
> +     struct sockaddr_un addr = {0};
> +     char socket_path[BUF_SIZE];

BUF_SIZE is not yet defined - it is in the next patch.
Pull the #define back into this patchset; now this patch
(without next one applied) won't build. With that fix;

Acked-by: Harry van Haaren <[email protected]>

Reply via email to