Sending a newer version with the fix. Kindest regards, Raslan Darawsheh
> -----Original Message----- > From: Iremonger, Bernard <[email protected]> > Sent: Wednesday, October 17, 2018 3:59 PM > To: Yigit, Ferruh <[email protected]>; Raslan Darawsheh > <[email protected]>; Wu, Jingjing <[email protected]> > Cc: Thomas Monjalon <[email protected]>; [email protected]; Shahaf > Shuler <[email protected]>; Xueming(Steven) Li > <[email protected]>; Ori Kam <[email protected]>; > [email protected]; [email protected] > Subject: RE: [PATCH v5 1/3] app/testpmd: move dumping packets to a > separate function > > Hi Raslan, > > > -----Original Message----- > > From: Yigit, Ferruh > > Sent: Wednesday, October 17, 2018 1:28 PM > > To: Raslan Darawsheh <[email protected]>; Wu, Jingjing > > <[email protected]> > > Cc: [email protected]; [email protected]; [email protected]; > > [email protected]; [email protected]; > > [email protected]; [email protected]; > Iremonger, > > Bernard <[email protected]> > > Subject: Re: [PATCH v5 1/3] app/testpmd: move dumping packets to a > > separate function > > > > On 10/17/2018 8:27 AM, Raslan Darawsheh wrote: > > > verbosity for the received/sent packets is needed in all of the > > > forwarding engines so moving it to be in a separate function > > > > > > Acked-by: Bernard Iremonger <[email protected]> > > > Signed-off-by: Raslan Darawsheh <[email protected]> > > > > <...> > > > > > +static inline void > > > +dump_pkt_burst(uint16_t port_id, uint16_t queue, struct rte_mbuf > *pkts[], > > > + uint16_t nb_pkts, int is_rx) { > > > > This is causing build error when only this patch applied: > > > > .../app/test-pmd/util.c:25:1: error: unused function 'dump_pkt_burst' > > [-Werror,-Wunused-function] > > dump_pkt_burst(uint16_t port_id, uint16_t queue, struct rte_mbuf > > *pkts[], ^ > > Builds ok with gcc but fails with clang > > Regards, > > Bernard.
