Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, October 24, 2018 8:55 PM > To: Iremonger, Bernard <bernard.iremon...@intel.com> > Cc: Wu, Jingjing <jingjing...@intel.com>; Lu, Wenzhuo > <wenzhuo...@intel.com>; dev@dpdk.org; ophi...@mellanox.com; > wis...@mellanox.com; Yigit, Ferruh <ferruh.yi...@intel.com>; > arybche...@solarflare.com > Subject: Re: [PATCH 4/5] app/testpmd: move ethdev events registration > > 24/10/2018 17:55, Iremonger, Bernard: > > Hi Thomas, > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > +/* Pretty printing of ethdev events */ static const char * const > > > +eth_event_desc[] = { > > > + [RTE_ETH_EVENT_UNKNOWN] = "unknown", > > > + [RTE_ETH_EVENT_INTR_LSC] = "LSC", > > > > How about replacing "LSC" with "interrupt link status change" > > When it is printed, "event" is appended. > So I think "interrupt" is a bit too much. > OK for "link state change"?
Yes, > > > + [RTE_ETH_EVENT_QUEUE_STATE] = "queue state", > > > + [RTE_ETH_EVENT_INTR_RESET] = "interrupt reset", Should "interrupt" be dropped from "interrupt reset" too for consistency? > > > + [RTE_ETH_EVENT_VF_MBOX] = "VF mbox", > > > + [RTE_ETH_EVENT_IPSEC] = "IPsec", > > > + [RTE_ETH_EVENT_MACSEC] = "MACsec", > > > + [RTE_ETH_EVENT_INTR_RMV] = "device removal", > > > > How about replacing "device removal" with "interrupt device removal" > > For same reason, I think "device removal" is enough. > It will be printed as "device removal event". > > Regards, Bernard.
