On Wed, Oct 24, 2018 at 04:32:32PM +0200, Jens Freimann wrote: > Add support to dump packed virtqueue data to the > VIRTQUEUE_DUMP() macro. > > Signed-off-by: Jens Freimann <[email protected]> > Reviewed-by: Maxime Coquelin <[email protected]> > --- > drivers/net/virtio/virtqueue.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h > index 3d512fe30..2af1bc259 100644 > --- a/drivers/net/virtio/virtqueue.h > +++ b/drivers/net/virtio/virtqueue.h > @@ -368,6 +368,15 @@ virtqueue_notify(struct virtqueue *vq) > uint16_t used_idx, nused; \ > used_idx = (vq)->vq_ring.used->idx; \ > nused = (uint16_t)(used_idx - (vq)->vq_used_cons_idx); \ > + if (vtpci_packed_queue((vq)->hw)) { \ > + PMD_INIT_LOG(DEBUG, \ > + "VQ: - size=%d; free=%d; used_cons_idx=%d; avail_idx=%d;" \ > + "VQ: - avail_wrap_counter=%d; used_wrap_counter=%d", \
Please remove the second "VQ: -" as they are on the same line. > + (vq)->vq_nentries, (vq)->vq_free_cnt, (vq)->vq_used_cons_idx, \ > + (vq)->vq_avail_idx, (vq)->vq_ring.avail_wrap_counter, \ > + (vq)->vq_ring.used_wrap_counter); \ > + break; \ > + } \ > PMD_INIT_LOG(DEBUG, \ > "VQ: - size=%d; free=%d; used=%d; desc_head_idx=%d;" \ > " avail.idx=%d; used_cons_idx=%d; used.idx=%d;" \ > -- > 2.17.1 >

