HI <snipped> > > > +/**< Enable port debug. */ > In comment , Enable displaying port info?
ok > > > +static uint32_t enable_dbg_port; > Do you want to consider replacing "debug" to "show" in code here other > places? As you have already changed the commands to "show." > If the variable naming has to change, I can do > ring_name = optarg; > How about doing memcpy instead of pointer assignment? Similarly below. > Though I don't see issue here. But safe to use memcpy. > I will check this internally, I also think this is safe as it is pointer argv elements. I have taken the same design from /* Print xstat single value given by name*/ if (!strncmp(long_option[option_index].name, "xstats-name", MAX_LONG_OPT_SZ)) { enable_xstats_name = 1; xstats_name = optarg; <snipped>