> -----Original Message----- > From: Burakov, Anatoly > Sent: Friday, October 26, 2018 4:22 PM > To: Stojaczyk, Dariusz <[email protected]>; [email protected] > Cc: Zhang, Qi Z <[email protected]>; [email protected] > Subject: Re: [dpdk-dev] [PATCH] eal: fix rte_mp_request_sync() memleak > on device hotplug > > <SNIP> > > This is correct but incomplete. There are also numerous error conditions > which check for number of received responses to be a particular number, > and if the number don't match, we just exit without freeing memory. > Those errors need to free the memory as well. >
Yup, thanks. I pushed v2 with one extra free() in the function notifying secondary processes. The function which notifies the primary process has a similar error check - - `if (mp_reply.nb_received == 1)` - but I figured if there's more than 1 primary process replying, then the memory leak is your smallest problem. > -- > Thanks, > Anatoly
