31/10/2018 14:59, Radu Nicolau: > After the patch below the call to rte_eth_bond_8023ad_agg_selection_set > from probe() segfaults; there is no need to call the function, just set > the mode directly. > > Fixes: 391797f04208 ("drivers/bus: move driver assignment to end of probing")
It would not segfault if you call rte_eth_dev_probing_finish() at the real end of the probing function. Then the port will be considered not valid in rte_eth_bond_8023ad_agg_selection_set(). It does not solve your problem but it is more correct. So I suggest to revert this patch (which was a wrong fix): http://git.dpdk.org/dpdk/commit/?id=1620175 Then the issue is to allow configuring a port before the end of probing. This patch is workarounding the public API which checks port validity. I think it is a good approach.